Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export symbols when compiling glm as shared lib #1280

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

seanharmer
Copy link

Possible fix for #1279

@orion160
Copy link

Oh, great!
But I think that it does not export the symbols of free functions

@seanharmer
Copy link
Author

Do you have an example please? The ones I looked at all seemed to be inline. If you can point me at an example I can try to export those too.

@orion160
Copy link

https://github.com/g-truc/glm/blob/master/glm/detail/setup.hpp
There are GLM_FUNC_QUALIFIER and GLM_FUNC_DECL

Mmmmm I dont know if inline functions have to be exported, but the linker has to know symbol names to perform relocation. So its probably that it is needed

@orion160
Copy link

@christophe-lunarg what do you think?

@xiaozhuai
Copy link

xiaozhuai commented May 31, 2024

install(FILES ${CMAKE_CURRENT_BINARY_DIR}/glm_export.h
        DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/glm)

Anyway, install things should stay in if(GLM_BUILD_INSTALL) scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants